(#3930) Remove Obsolete Members - #3931
Draft
gep13 wants to merge 1 commit into
Draft
Conversation
Remove every member marked [Obsolete("... will be removed in v3 ...")]
now that v3 is the next major release: the snake_case method
forwarders, deprecated overloads, SCREAMING_CASE source-type constant
aliases, and other members kept only for backward compatibility.
The few internal callers of removed members are repointed to their
surviving equivalents - Options.GetOptionForName("<>") becomes the
KeyedCollection indexer (Contains("<>") ? this["<>"] : null) - and a
dangling <see cref="SourceType"/> that referenced a removed member is
downgraded to <c>SourceType</c>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Removes every member marked
[Obsolete("... will be removed in v3 ...")]from Chocolatey CLI now that v3 is the next major release — the
snake_case method forwarders, deprecated overloads, the SCREAMING_CASE
source-type constant aliases, and other members kept only for backward
compatibility. The few internal callers of removed members are repointed
to their surviving equivalents, and a dangling
SourceTypedoc cref iscorrected. ~181 files, ~3,800 deletions.
Motivation and Context
These members were retained only for backward compatibility and were all
annotated for removal in v3. With v3 as the next major release, this
clears the deprecated surface in a single pass so the codebase no longer
carries the obsolete forwarders and aliases.
Testing
build.debug.bat --target=Run-ILMergecompiles and ILMerges the CLIclean against the reduced surface - 0 errors.
and confirm.
Operating Systems Testing
Dev VM 4
Change Types Made
Change Checklist
Related Issue
Fixes #3930