Skip to content

Remove deprecation note from ListLookup #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

carlosedp
Copy link
Contributor

The comment on ListLookup documentation does not reflect current use of the API. As seen, the it's a pattern in use for Decoders on multiple cores like:

And many others.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation

API Impact

No impact, documentation change.

Backend Code Generation Impact

No impact.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer
Copy link
Member

I'd like to deprecate this API, asking user switching to decoder API. Since this API will introduce a cascade Mux rather than parallel pla, which can be the critical path in most of CPU designs. So I still encourage designers switching to decoder for the this performance issue.

@ekiwi
Copy link
Contributor

ekiwi commented Nov 24, 2021

@sequencer Would you mind making a PR on @carlosedp chiselv design to show how to move to the decoder API? Then we could always point people to your change to show how to migrate.

@sequencer
Copy link
Member

sequencer commented Nov 24, 2021

carlosedp/chiselv#2 is sent.

@sequencer
Copy link
Member

A deprecation PR #2259 is sent, fell free to open this if @carlosedp has more questions ;p

@sequencer sequencer closed this Nov 24, 2021
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants