Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Flatpak build #262

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

WIP: Flatpak build #262

wants to merge 3 commits into from

Conversation

Murmele
Copy link
Contributor

@Murmele Murmele commented Dec 18, 2024

Fixes #241

Reason: it is easier to change when the master changes
Files: build_flatpak.yml
Files: com.github.chipmuenk.pyfda.yaml and python3-requirements.json
Copy link
Owner

@chipmuenk chipmuenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I'll test the build process later on in detail!

@Murmele
Copy link
Contributor Author

Murmele commented Dec 18, 2024

This looks great, I'll test the build process later on in detail!

Perhabs it does not work yet. I have to fix an issue with the kiwi package

@Murmele
Copy link
Contributor Author

Murmele commented Dec 18, 2024

@chipmuenk
Copy link
Owner

I'm a bit confused about the state of this PR: Is it already ready for review / merge or are you working on it? There is no need to hurry, but I'm not sure whether I have to review / accept the changes.

@Murmele
Copy link
Contributor Author

Murmele commented Dec 19, 2024

@chipmuenk I just created the Mr, but I am not yet finished. I will set it to ready once it is finished. If you prefer, I can also close it and reopen once finished?

@chipmuenk
Copy link
Owner

No, that's fine. I just wasn't sure whether an action was expected from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Created flatpak (Github action script) cannot be accessed
2 participants