Skip to content

Add $hintSelector variable#158

Open
ryanve wants to merge 2 commits into
chinchang:masterfrom
ryanve:selector
Open

Add $hintSelector variable#158
ryanve wants to merge 2 commits into
chinchang:masterfrom
ryanve:selector

Conversation

@ryanve

@ryanve ryanve commented Dec 15, 2016

Copy link
Copy Markdown
Contributor

This would allow customizing like

$hintSelector: '.hint';
$hintPrefix: 'hint--';

to use like

<div class="hint hint--top">example</div>

and make it easy to customize via .hint

@chinchang

Copy link
Copy Markdown
Owner

@ryanve Thanks for the pull request. I would just like to know if there was any use case of yours to change the selector of the tooltips?

@ryanve

ryanve commented Dec 20, 2016

Copy link
Copy Markdown
Contributor Author

Of course :) I'm using aria-label for the tooltip content so the only way to customize all tooltips would be by the somewhat cumbersome attribute selectors. Being able to use a simple base class like .hint seems cleaner and less error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants