Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user/vis: new package #3328

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

user/vis: new package #3328

wants to merge 3 commits into from
+96 −0

Conversation

apprehensions
Copy link
Contributor

@apprehensions apprehensions commented Dec 22, 2024 •
edited
Loading

Description

  • main/lua5.4-lpeg: new package
  • user/libtermkey: new package
  • user/vis: new package

Checklist

q66
q66 reviewed Dec 23, 2024
View reviewed changes
main/lua5.4-lpeg/update.py Outdated Show resolved Hide resolved
q66
q66 reviewed Dec 23, 2024
View reviewed changes
user/libtermkey/template.py
@@ -0,0 +1,21 @@
pkgname = "libtermkey"
Copy link
Member

@q66 q66 Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we previously removed libtermkey because it's dead/deprecated upstream (e3b484d)

Copy link
Contributor Author

@apprehensions apprehensions Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately it is still a dependency of vis.

martanne/vis#1071

the alternative discussed in the PR to remove curses support is possible, but it may be incompatible with terminals.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about vendoring libtermkey within user/vis?

Besides it consists of only 3 C files which could always be included in vis directly (but I prefer not to do so).

Copy link
Member

@q66 q66 Jan 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendoring it should be fine yeah (should be either compiled in, or built as a static library and then linked in)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempting to vendor it has been a pain in the ass since im not familiar with this, is vendoring it truly preferred?

@apprehensions apprehensions force-pushed the vis branch 3 times, most recently from 6c69622 to 561e578 Compare December 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q66 q66 q66 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apprehensions @q66