Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbuild: fix prepare-upgrade only updating one sha256 #3198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gnarwhal
Copy link
Contributor

If multiple sha256 strings in a template start as the same initial value (i.e. all the empty string) before prepare-upgrade is run, prepare-upgrade will only update the first source's checksum.

Example of old behaviour:

sha256 = [
    "",
    "",
]

./cbuild prepare-upgrade user/foo

sha256 = [
    "2bdb2943db86338fdfcb452fbb6d84e7a4ad05712492dd564d4e5c84a4c8d750",
    "",
]

./cbuild prepare-upgrade user/foo

sha256 = [
    "2bdb2943db86338fdfcb452fbb6d84e7a4ad05712492dd564d4e5c84a4c8d750",
    "8fa3b0b66914ae2dd4ddef9a954f614c5b3eb6ac9d80ee61ae2d08e3178507ec",
]

@q66
Copy link
Member

q66 commented Nov 22, 2024

i'm not quite sure if this is enough, i'll need some time to think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants