Skip to content

Conversation

sotayamashita
Copy link

Summary

This PR adopts the upstream feature that migrates from custom menu implementation to Obsidian's native menu system.

What's Changed

✨ Improvements: Native Obsidian Menu Integration

Migrates the highlighter menu from a custom DIV-based implementation to Obsidian's native menu system. This provides better integration with Obsidian's UI and improved keyboard navigation support.

📝 Changes Included

  • Menu System: Replaced custom menu div with native Obsidian menu items
  • Icons: Added custom icons to the native menu implementation
  • Styles: Removed custom container styles to leverage Obsidian's built-in menu styles
  • Accessibility: Improved keyboard navigation for menu selection

🎯 Benefits

  • ✅ Better integration with Obsidian's native UI
  • ✅ Improved keyboard navigation support
  • ✅ Cleaner codebase with less custom CSS
  • ✅ More consistent user experience with other Obsidian menus

Related Issues

Testing

  • ✅ Built successfully with npm run build
  • ✅ Menu appears correctly with native Obsidian styling
  • ✅ Custom icons display properly in menu items
  • ✅ Keyboard navigation works as expected
  • ✅ All highlighter options function correctly

Credits

Full credit goes to @andorx for the original implementation. This fork preserves the original authorship and includes proper attribution via cherry-pick -x.

renovate bot and others added 22 commits September 2, 2025 21:44
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* added: context menu default highlighter option and behavior

* updated: unify setting label phrasing to start with 'Choose'

* updated: reorder settings to method → style → context menu

* added: AGENTS.md

* refactor: centralize 'palette' sentinel and streamline context-menu default execution
* updated: README – simplify for community fork; clarify fork status and donations

* fixed: license – set package.json to MPL-2.0 to match upstream
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlightr No Longer Working w Obsidian v0.15.3

2 participants