Fix if(DEFINED ENV{var}) for CMAKE_* variables#281
Open
Takishima wants to merge 2 commits intocheshirekow:masterfrom
Open
Fix if(DEFINED ENV{var}) for CMAKE_* variables#281Takishima wants to merge 2 commits intocheshirekow:masterfrom
Takishima wants to merge 2 commits intocheshirekow:masterfrom
Conversation
Kaffeine
reviewed
Jan 29, 2024
cmakelang/lint/test/lint_tests.cmake
Outdated
| # test: missing-final-newline | ||
| # expect: C0304 | ||
| # This file is missing a final newline No newline at end of file | ||
| # This file is missing a final newline |
There was a problem hiding this comment.
The commit adds newline and thus breaking the expected check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MRE:
Expected:
Actual:
This PR addresses this by patching the
LintChecker::check_tokens()function to check for cases where the first group of the match happens to beENV{.