-
-
Notifications
You must be signed in to change notification settings - Fork 13
add jsonlog log_destination #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi, @nikhrom This is a good feature, but the tests fail with an error: |
|
Ooops |
|
Please check it again |
|
Hello! |
|
Hello |
|
When I started adding log_directory, I realized that I might have misunderstood what was required of me. I added log_directory to the source config, from where I then forward to collector. Please check |
|
@nikhrom Thank you, I asked for exactly what you delivered. |
|
Wait with approve. I had problems with log unmarhsalling while using it at work. I need to figure out what caused the problem |
|
I don't think we'll have any issues with approval, but there are a few blockers for the current release (1.0). If you need to get an image quickly, I recommend cherry-picking it and pushing the MP to the 0.15 branch. |
It is worth noting that the marshaling issue can cause excessive load on the disk subsystem and CPU, as the exporter starts reporting problems when parsing JSON logs. |
No, I don't need approval right now. There are logic problems in the current PR that lead to errors in json.Unmarshal when parse json logs. That's why I'm asking you to wait for approval. |
|
@nikhrom Hi, pgSCV shouldn't create any additional, excessive load on the disk or cpu subsystems on the database server. Please run additional tests and try to fix the issue. Thank you! |
|
@nikhrom and please, fix test |
Added support for jsonlog log_destination
Now, based on log_destination, the corresponding LogParser will be used.
I also removed the log collector skip if postgres is not a local service but add warn message. This is necessary to be able to mount a directory with postgres logs in a pgscv container, in case pgscv is running in a separate container.