Skip to content

Updating for Ruby 3.4 and Cookstyle #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Updating for Ruby 3.4 and Cookstyle #62

wants to merge 10 commits into from
+141 −16

Conversation

johnmccrae
Copy link

Description

Chef-19 is moving to Ruby 3.4 and Cookstyle. Here we update the code to reflect these changes but stay compatible with Chef-18

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae johnmccrae requested review from a team as code owners May 14, 2025 21:05
@johnmccrae johnmccrae added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label May 14, 2025
tpowell-progress
tpowell-progress requested changes May 15, 2025
View reviewed changes
Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on why the dependencies were "added" (because of their removal from the standard library as of 3.5, presumably)

tas50
tas50 reviewed May 15, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tas50 tas50 tas50 left review comments

@vkarve-chef vkarve-chef vkarve-chef approved these changes

@poorndm poorndm poorndm approved these changes

@tpowell-progress tpowell-progress tpowell-progress approved these changes

Assignees
No one assigned
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnmccrae @tas50 @vkarve-chef @poorndm @tpowell-progress