Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop correction #436

Merged
merged 9 commits into from
Mar 27, 2025
Merged

Rubocop correction #436

merged 9 commits into from
Mar 27, 2025

Conversation

tpowell-progress
Copy link
Contributor

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

sean-simmons-progress and others added 7 commits February 11, 2025 16:51
@sean-simmons-progress
enabling the public build again
afd4053 
Signed-off-by: Sean Simmons <[email protected]>
@sean-simmons-progress
updating runner, as 1804 is gone
5695218 
Signed-off-by: Sean Simmons <[email protected]>
@sean-simmons-progress
adding in a dev container process for windows and linux
cb71483 
this is for local testing only

Signed-off-by: Sean Simmons <[email protected]>
@sean-simmons-progress
testing in container fixed
9120e61 
missing a microsoft dev pacakges, running a quick temp fix to address the immediate need

Signed-off-by: Sean Simmons <[email protected]>
@sean-simmons-progress
testing with privileged
72d4971 
Signed-off-by: Sean Simmons <[email protected]>
@sean-simmons-progress
removing option
77705ff 
Signed-off-by: Sean Simmons <[email protected]>
@tpowell-progress
Rubocop correction
b2cb6e4 
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress tpowell-progress marked this pull request as ready for review March 5, 2025 22:49
@tpowell-progress tpowell-progress requested review from a team as code owners March 5, 2025 22:49
@tpowell-progress tpowell-progress changed the base branch from sean-simmons-progress/PublicVerifyFix to main March 5, 2025 22:49
@tpowell-progress tpowell-progress requested a review from a team as a code owner March 5, 2025 22:49
@tpowell-progress
Bump up timeout
8f9868d 
Signed-off-by: Thomas Powell <[email protected]>
@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
1 New issue
2 Security Hotspots

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Simplecov Report

Covered Threshold
97.76% 90%

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
2 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sean-simmons-progress sean-simmons-progress merged commit 0f4fd1a into main Mar 27, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-simmons-progress sean-simmons-progress sean-simmons-progress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpowell-progress @sean-simmons-progress