Skip to content

Conversation

@vinay033
Copy link
Collaborator

πŸ”© Description: What code changed, and why?

Upgrade the angular version and node version
Angular: 17.3.0 β†’ 19.2.14
Node.js: 18.19.1 β†’ 22.17.0

⛓️ Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-23804
https://progresssoftware.atlassian.net/browse/CHEF-23850

πŸ‘ Definition of Done

upgrade the angular and node version with all the dependencies, also added the required config changes and component changes.

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@netlify
Copy link

netlify bot commented Jul 30, 2025

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit a6442cb
πŸ” Latest deploy log https://app.netlify.com/projects/chef-automate/deploys/688d34c0df7612000877e330

@vinay033 vinay033 self-assigned this Jul 30, 2025
@vinay033 vinay033 requested a review from Copilot July 30, 2025 07:41

This comment was marked as outdated.

@vinay033 vinay033 requested a review from Copilot August 1, 2025 09:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Angular from version 17.3.0 to 19.2.14 and Node.js from 18.19.1 to 22.17.0, along with necessary configuration changes and component updates to maintain compatibility.

  • Updates moment.js import statements from namespace imports to default imports
  • Adds standalone: false declarations to all Angular components for compatibility with Angular 19
  • Fixes test configurations and mock component usage for updated test infrastructure

Reviewed Changes

Copilot reviewed 299 out of 416 changed files in this pull request and generated 4 comments.

File Description
Multiple component files Added standalone: false to component decorators for Angular 19 compatibility
Multiple spec files Updated test configurations and mock component imports
Various TypeScript files Changed moment import from import * as moment to import moment

Signed-off-by: vinay sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants