-
Notifications
You must be signed in to change notification settings - Fork 116
Update Angular version to 19.2.14 and node version to 22.17.0 #8948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vinay033
wants to merge
6
commits into
main
Choose a base branch
from
Vinay/CHEF-23804-angular-and-node-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vinay sharma <[email protected]>
Signed-off-by: vinay sharma <[email protected]>
Signed-off-by: vinay sharma <[email protected]>
Signed-off-by: vinay sharma <[email protected]>
π· Deploy Preview for chef-automate processing.
|
Signed-off-by: vinay sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades Angular from version 17.3.0 to 19.2.14 and Node.js from 18.19.1 to 22.17.0, along with necessary configuration changes and component updates to maintain compatibility.
- Updates moment.js import statements from namespace imports to default imports
- Adds
standalone: falsedeclarations to all Angular components for compatibility with Angular 19 - Fixes test configurations and mock component usage for updated test infrastructure
Reviewed Changes
Copilot reviewed 299 out of 416 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Multiple component files | Added standalone: false to component decorators for Angular 19 compatibility |
| Multiple spec files | Updated test configurations and mock component imports |
| Various TypeScript files | Changed moment import from import * as moment to import moment |
components/automate-ui/src/app/page-components/search-bar/search-bar.component.ts
Show resolved
Hide resolved
components/automate-ui/src/app/page-components/run-list/run-list.component.ts
Show resolved
Hide resolved
components/automate-ui/src/app/page-components/delta-viewer/delta-viewer.component.ts
Show resolved
Hide resolved
components/automate-ui/src/app/modules/infra-proxy/paginator/paginator.component.ts
Show resolved
Hide resolved
Signed-off-by: vinay sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π© Description: What code changed, and why?
Upgrade the angular version and node version
Angular: 17.3.0 β 19.2.14
Node.js: 18.19.1 β 22.17.0
βοΈ Related Resources
https://progresssoftware.atlassian.net/browse/CHEF-23804
https://progresssoftware.atlassian.net/browse/CHEF-23850
π Definition of Done
upgrade the angular and node version with all the dependencies, also added the required config changes and component changes.
π How to Build and Test the Change
β Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
π· Screenshots, if applicable