Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make trigger condition optional #871

Merged
merged 1 commit into from
Feb 24, 2025
Merged

feat: make trigger condition optional #871

merged 1 commit into from
Feb 24, 2025

Conversation

ChibiBlasphem
Copy link
Contributor

@ChibiBlasphem ChibiBlasphem commented Feb 24, 2025 •
edited
Loading

This PR makes scenario trigger condition optional by:

  • Setting the trigger_condition_ast_expression field to NULL when patching scenario iteration if the trigger is an undefined node
  • Skipping trigger execution while evaluating scenario if the trigger is nil
  • Getting rid of validation scenario error when trigger is nil

Frontend PR: checkmarble/marble-frontend#711

@ChibiBlasphem ChibiBlasphem requested a review from a team February 24, 2025 13:14
@ChibiBlasphem ChibiBlasphem mentioned this pull request Feb 24, 2025
Merged
Pascal-Delange
Pascal-Delange approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@Pascal-Delange Pascal-Delange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChibiBlasphem ChibiBlasphem merged commit 5d45d45 into main Feb 24, 2025
3 checks passed
@ChibiBlasphem ChibiBlasphem deleted the feat/make-iteration-trigger-optional branch February 24, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pascal-Delange Pascal-Delange Pascal-Delange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChibiBlasphem @Pascal-Delange