Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenAPI validation #864

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix OpenAPI validation #864

merged 1 commit into from
Feb 19, 2025

Conversation

apognu
Copy link
Contributor

@apognu apognu commented Feb 19, 2025

This fixes the OpenAPI generation in two ways:

  • $ref becomes omitempty
  • When we build the endpoint matrix /ingest/* / /ingest/*/multiple / POST / PATCH, we inadvertently modified pointers to the previously-built object, making the final output invalid.

@apognu apognu added bug Something isn't working go Pull requests that update Go code labels Feb 19, 2025
@apognu apognu self-assigned this Feb 19, 2025
@apognu apognu marked this pull request as draft February 19, 2025 13:33
@apognu apognu marked this pull request as ready for review February 19, 2025 13:40
@apognu apognu merged commit f2f9928 into main Feb 19, 2025
3 checks passed
@apognu apognu deleted the fix/openapi-deepcopy branch February 19, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pascal-Delange Pascal-Delange Pascal-Delange approved these changes

Assignees

@apognu apognu

Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apognu @Pascal-Delange