Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pascal/mar 734 return information on missing configuration in feature #821

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Pascal/mar 734 return information on missing configuration in feature #821

merged 1 commit into from
Feb 26, 2025

Conversation

Pascal-Delange
Copy link
Contributor

@Pascal-Delange Pascal-Delange commented Feb 4, 2025 •
edited by carere
Loading

  • feature access has a new option "missing_configuration" for a feature that is accessible but that has missing dependencies (computed from checking if the minimal required environment variables are set, not by checking that the variables are valid end to end)
  • return "test" instead of "restricted" for all features if test mode is enabled, AKA if the firebase emulator host is set

Related Frontend PR checkmarble/marble-frontend#715

@linear Linear
Copy link

linear bot commented Feb 4, 2025

MAR-734 Return information on missing configuration in feature access DTO

@Pascal-Delange Pascal-Delange changed the base branch from main to feat/sanctions-in-iterations February 4, 2025 10:58
@Pascal-Delange Pascal-Delange mentioned this pull request Feb 4, 2025
Closed
@Pascal-Delange Pascal-Delange requested a review from carere February 4, 2025 11:03
@Pascal-Delange Pascal-Delange force-pushed the feat/sanctions-in-iterations branch from 51be2b5 to 0c8f500 Compare February 6, 2025 10:50
@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from ea1d052 to 3a473e2 Compare February 6, 2025 10:58
@Pascal-Delange Pascal-Delange marked this pull request as ready for review February 7, 2025 09:20
@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from 3a473e2 to b84ef5b Compare February 7, 2025 09:25
@Pascal-Delange Pascal-Delange force-pushed the feat/sanctions-in-iterations branch from de56e6e to 0c82dbd Compare February 7, 2025 20:17
Base automatically changed from feat/sanctions-in-iterations to main February 10, 2025 13:06
@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from b84ef5b to 056e637 Compare February 10, 2025 13:08
@carere carere force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from 056e637 to 8cb2708 Compare February 15, 2025 15:18
@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from 8cb2708 to 50c32c3 Compare February 17, 2025 16:17
@apognu apognu force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from 50c32c3 to 661db32 Compare February 18, 2025 13:27
@carere carere force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from 661db32 to e8a245c Compare February 26, 2025 12:05
@carere carere force-pushed the pascal/mar-734-return-information-on-missing-configuration-in-feature branch from e8a245c to 7deef2d Compare February 26, 2025 15:59
@carere carere mentioned this pull request Feb 26, 2025
Merged
@carere carere merged commit 123abb2 into main Feb 26, 2025
3 checks passed
@carere carere deleted the pascal/mar-734-return-information-on-missing-configuration-in-feature branch February 26, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carere carere carere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pascal-Delange @carere