Cache node evaluation to reuse results within a run #811
+435
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apognu
added
enhancement
apognu
force-pushed
the
feat/ast-eval-deduplication
branch
2 times, most recently
from
fc96036 to
4384164
Compare
This will now cache rule evaluation between AST node of the same run. It prevents two equal AST nodes from executing at the same time, using the result for all concurrent instances. Also, it will use the cached result in subsequent instance of the same AST node.
apognu
force-pushed
the
feat/ast-eval-deduplication
branch
from
4384164 to
752dc4d
Compare
added 3 commits
January 30, 2025 22:18
Pascal-Delange
approved these changes
Jan 31, 2025
| Children []EvaluationStats | ||
| } | ||
|
|
||
| func BuildEvaluationStats(root NodeEvaluation, parentCached bool) EvaluationStats { |
There was a problem hiding this comment.
Seeing how the main source of execution delay by is linked to computing aggregates today, I think this may be at the same time a bit overkill for generic nodes and lack of detailed breakdown for aggregates nodes (and perhaps tomorrow, for sanction check/api call nodes)
There was a problem hiding this comment.
(we can keep it though, it's fine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AST language is idempotent within a single run. We can assume that it is expected a node configured the same way returns the same result within a single run of a scenario.
This PR makes it so: