Skip to content

fix: Send DC_EVENT_MSGS_CHANGED without IDs for ephemeral messages and add DC_EVENT_MSG_DELETED #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Jun 6, 2023

Fixes #4415

@link2xt link2xt requested a review from Simon-Laux June 6, 2023 00:04
@link2xt link2xt changed the title Send DC_EVENT_MSGS_CHANGED without IDs for ephemeral messages and add DC_EVENT_MSG_DELETED fix: Send DC_EVENT_MSGS_CHANGED without IDs for ephemeral messages and add DC_EVENT_MSG_DELETED Jun 6, 2023
@link2xt link2xt requested a review from r10s June 6, 2023 14:00
@link2xt
Copy link
Collaborator Author

link2xt commented Jun 6, 2023

CI failure wrt cargo-deny is fixed in #4458, which should be merged first.

link2xt added 3 commits June 7, 2023 00:27
Specifying msg IDs that cannot be loaded in the event payload
results in an error when the UI tries to load the message.
Instead, emit an event without IDs
to make the UI reload the whole messagelist.
@link2xt link2xt force-pushed the link2xt/msg-deleted branch from 0664263 to bb2fc3c Compare June 7, 2023 00:27
@link2xt link2xt merged commit e6d9a49 into master Jun 7, 2023
@link2xt link2xt deleted the link2xt/msg-deleted branch June 7, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message deletion event
3 participants