Improved 64-bit support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpected Seems to work, but z_stream_64_8 seems like it should be wrong
I get weird errors on x64 when comparing Integers to zero
charonn0
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves 64 bit support by changing how the stream structure is allocated and accessed. Because the alignment and member size (e.g. Int32 vs Int64) of the structure can vary depending on the OS, platform, and the compiler used to build zlib, the FlateEngine class has been changed to more fully encapsulate it. The actual size in memory of the structure is detected at runtime and the appropriate alignment, etc. is taken into account when accessing members. This allows the Inflater and Deflater subclasses to work without knowing whether they're in 32-bit or 64-bit.