Skip to content

Conversation

@lrstanley
Copy link
Contributor

Changes in this PR

  • Updated teatest v2 to use charm.land & bubbletea 2.0.0-rc.1 from beta.3

  • Updated snapshots, though not sure if there should be a change. Looks like the core of the snapshots is still correct, but rendering adds a few new characters around the resulting text, I assume due to how bubbletea v2s new renderer does this.

  • I have read CONTRIBUTING.md.

  • I have created a discussion that was approved by a maintainer (for new features).

@lrstanley lrstanley requested a review from caarlos0 as a code owner November 10, 2025 11:17
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.01%. Comparing base (3bf63bc) to head (34abe26).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #637       +/-   ##
===========================================
+ Coverage   31.69%   91.01%   +59.32%     
===========================================
  Files         162        2      -160     
  Lines       14518      256    -14262     
===========================================
- Hits         4601      233     -4368     
+ Misses       9636       17     -9619     
+ Partials      281        6      -275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lrstanley
Copy link
Contributor Author

Looks like tests are failing on Windows due to \r line endings being added, I suspect something windows-terminal-specific. With teatest, and the new tea.View being used, which seems to render more raw terminal sequences than before, what's the best way to resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant