Skip to content

Conversation

@Sojamann
Copy link

@Sojamann Sojamann commented Dec 8, 2023

This is the first draft for #153

Note:

  • no code comments exist as of yet

@Sojamann Sojamann changed the title The progress bar for #153 feat(progress): the progress cmd for #153 Dec 8, 2023
@Sojamann
Copy link
Author

I think additionally it would also be cool if one could either do

... task .... | gum progress --eta --limit 1000 --elapsed

so that the user could enable printing of some stats

or what tqdm does ... allowing the user to specify the layout of the bar

# when there is a limit
... task ..... | gum progress --limit 1000 --fmt '{{ .Title }} - {{ .Bar }} [{{ .Elapsed }} ~ ETA: {{ .ETA }}]'

# when there is no limit
... task ..... | gum progress --fmt '{{ .Title }} - Step: {{ .Iter }} [{{ .Elapsed }} ~ ETA: {{ .ETA }}]'

is this too much or something actually useful? @olivertzeng

@olivertzeng
Copy link

olivertzeng commented Dec 10, 2023

Great at least it works

@Sojamann Sojamann marked this pull request as ready for review December 16, 2023 14:46
@Sojamann
Copy link
Author

Going to change the help strings of the cli to show how a format string can be built..

@Sojamann
Copy link
Author

Rebased and squashed onto current main -> can be reviewed

@maxall41
Copy link

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants