feat(notification): alert on turn completion and permission request #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amolith
requested review from
raphamorim and
tauraamui
and removed request for
a team
Amolith
force-pushed
the
1224-interaction-notifications
branch
from
f7b585a to
d35aa46
Compare
Contributor
Author
|
Hmm I've been using this since opening the PR and it seems like the sub-agent's session also sends a notification when it's finished, instead of just the main agent. I'll look into differentiating between them so the user isn't mistakenly notified when the sub-agent's done but the main agent isn't. |
Amolith
force-pushed
the
1224-interaction-notifications
branch
2 times, most recently
from
918a165 to
25116c2
Compare
Contributor
Author
|
I'm aware of the new conflicts, will get them resolved sometime in the next few days |
Amolith
force-pushed
the
1224-interaction-notifications
branch
from
25116c2 to
787c5dc
Compare
Contributor
Author
|
The Windows CI is very helpful 🙏 |
Amolith
force-pushed
the
1224-interaction-notifications
branch
from
02674b6 to
aebc12e
Compare
Member
|
@Amolith do you need an icon for this one? I'm looking forward to to getting this one in :) |
Contributor
Author
|
@meowgorithm yes, when you can! |
Add desktop notification system with delayed reminders: - Native notifications via beeep library - Agent completion notifications (cancelled on new user message) - Permission request notifications (cancelled on scroll/navigation/grant/deny) - Configurable via DisableNotifications option Implementation: - Notifier interface for scheduling delayed notifications with cancellation - Agent schedules completion notifications on turn end - Permission service schedules reminders when requesting permission - Permission dialog emits interaction events on first user action - Both services track and cancel scheduled notifications per session/tool call Resolves: charmbracelet#1224 Resolves: charmbracelet#390 References: charmbracelet#230 Co-authored-by: Crush <[email protected]>
Co-authored-by: Crush <[email protected]>
Prevent completion notifications from showing when users are actively interacting with the chat interface (typing, clicking, scrolling, opening dialogs). Co-Authored-By: Crush <[email protected]>
Windows caught the permission notifier publishing its event before the notification had been scheduled, so subscribers saw zero queued calls. Move the scheduling step ahead of publish to ensure the notifier is ready before any listener inspects it. Assisted-by: GPT-5 via Crush
Amolith
force-pushed
the
1224-interaction-notifications
branch
from
aebc12e to
fe95055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement delayed and cancellable cross-platform desktop notifications using gen2brain/beeep. There's not yet an application icon as was requested in #230 (comment) but adding one once it exists, either before or after merge, should be simple based on beeep's docs.
I've tested and had it working on from-vanilla Arch and Debian 13, but I've not tested on any other system. I know all of the CoderAgent tests are failing, at least locally. How do I update those/resolve the issue?
Peek.2025-10-31.17-27.mp4
I found a couple potential issues in
internal/permission/permission.goandinternal/permission/permission_test.goand fixed them in individual commits (b35c245, f2288be, and f4ac82e) so they can be discarded if non-issues or unwanted or separated into individual PRs or something. The actual feature is 4ebd6fb and docs are d35aa46.CONTRIBUTING.md.created a discussion that was approved by a maintainer (for new features).talked with a maintainer in Discord and been assigned Notification mechanism for approvals #1224