refactor: simplify home.Dir()
#1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
reviewed
Nov 1, 2025
| return tmp | ||
| }) | ||
| // Dir returns the user home directory. | ||
| func Dir() string { |
There was a problem hiding this comment.
could probably keep the OnceValue though
There was a problem hiding this comment.
Agreed. Otherwise, this is a solid one, @andreynering.
There was a problem hiding this comment.
@caarlos0 I want to remove OnceValue because it hold a sync.Mutex inside and it locks reads.
If we want to cache it, then I think we can just compute on func init() and hold on a global unexported variable.
There was a problem hiding this comment.
Made changes. Take a look again.
andreynering
force-pushed
the
refactor-simplify-home
branch
from
32c130f to
74f63ac
Compare
meowgorithm
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
Nicely done. Might be worth at least logging the error but up to you.
Fwiw, here's the os.UserHomeDir definition.
https://cs.opensource.google/go/go/+/refs/tags/go1.25.3:src/os/file.go;l=608-627
* Realistically, this should almost never fail. * If it does, returning `""` probably makes more sense than a temp dir. Empty means Go will assume the working directory. * Getting rid of `sync.Once` is good as it locks and this can be called on every render cycle. (Used to compute `~` on the sidebar, etc).
andreynering
force-pushed
the
refactor-simplify-home
branch
from
74f63ac to
5b72be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
""probably makes more sense than a temp dir. Empty means Go will assume the working directory.sync.Onceis good as it locks and this can be called on every render cycle. (Used to compute~on the sidebar, etc).