Skip to content

Conversation

@plandem
Copy link

@plandem plandem commented Oct 25, 2025

  • I have read CONTRIBUTING.md.
  • I have created a discussion that was approved by a maintainer (for new features).

P.S.: IDE/Editor should start crush in acp mode, e.g. for Zed, its like this

  "agent_servers": {
    "crush": {
      "command": "crush",
      "args": ["acp"],
      "env": {}
    }
  },

TODO:

  • Initialization
  • Session Setup
    - Creating a Session
    - Loading Sessions
  • Prompt Turn
    - User Message
    - Agent Processing
    - Agent Reports Output (agent plan and etc)
    - Tool Invocation and Status Reporting
    - Stop Reasons
    - Cancellation
  • Content
    - Text Content
    - Reasoning Content
    - Image Content
    - Audio Content
    - Embedded Resource
    - Resource Link
  • Tool Calls
    - Creating
    - Updating
    - Requesting Permission
    - Status
    - Diffs
    - Following the Agent
  • File System
    - Reading Files
    - Writing Files
  • Terminals
    - Executing Commands
    - Embedding in Tool Calls
    - Getting Output
    - Waiting for Exit
    - Killing Commands
    - Releasing Terminals
  • Agent Plan
    - Creating Plans
    - Updating Plans
    - Dynamic Planning
  • Session Modes
    - Initial state
    - Setting the current mode
  • Slash commands
    - Advertising commands
    - Running commands
    - Dynamic updates
  • Transports
    - stdio
    - http

@plandem plandem requested a review from a team as a code owner October 25, 2025 12:49
@plandem plandem requested review from andreynering and meowgorithm and removed request for a team October 25, 2025 12:49
@charmcli
Copy link
Contributor

charmcli commented Oct 25, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@plandem
Copy link
Author

plandem commented Oct 25, 2025

I have read the Contributor License Agreement (CLA) and hereby sign the CLA.

@plandem plandem changed the title ACP mode prototype [Draft] ACP mode Oct 25, 2025
- added slash commands
@kujtimiihoxha
Copy link
Member

kujtimiihoxha commented Oct 27, 2025

@plandem I will keep an eye on this, let me know when its closer to ready for review, also we will soon release #1171 that is a major refactor of how the agent is setup and providers work. It should require some rebase probably

Also thanks for working on this 🙌

@plandem
Copy link
Author

plandem commented Oct 27, 2025

@plandem I will keep an eye on this, let me know when its closer to ready for review, also we will soon release #1171 that is a major refactor of how the agent is setup and providers work. It should require some rebase probably

Also thanks for working on this 🙌

Hi. Well, guess I need a parity check with features - e.g. crush has no "plan" or "mode" (except large/small?). Also what about content - image/audio?

@kujtimiihoxha
Copy link
Member

Hi. Well, guess I need a parity check with features - e.g. crush has no "plan" or "mode" (except large/small?). Also what about content - image/audio?

Crush does not yet support modes, But they are planned (we can add support when it lands)

We currently support images, for models that support it.

@andreynering andreynering marked this pull request as draft October 27, 2025 18:05
@plandem
Copy link
Author

plandem commented Oct 28, 2025

@kujtimiihoxha Im not sure that will have enough time to finish it. It requires to dig deeper into crush internals on top of the ACP docs. Probably would be way faster to finish it by somebody on crush's side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants