feat: add support for reasoning_content field in OpenAI provider #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for handling the 'reasoning_content' field in streaming responses from custom OpenAI-compatible APIs, allowing models that return reasoning content in this field to display their chain of thought in Crush UI. Previously, Crush only handled the 'reasoning' field but not the 'reasoning_content' field used by some custom servers.
mmangkad
requested review from
aymanbagabas and
kujtimiihoxha
and removed request for
a team
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
2 tasks
Jesssullivan
added a commit
to Jesssullivan/crush
that referenced
this pull request
Oct 24, 2025
Integrates PR charmbracelet#1294 from @mmangkad to add support for reasoning_content field in streaming responses from custom OpenAI-compatible servers. This complements our existing non-streaming reasoning_content support, providing full coverage for APIs like Z.AI GLM that use reasoning_content instead of the standard reasoning field used by OpenAI o1 models. Changes: - Add streaming reasoning_content extraction in openai.go - Emit EventThinkingDelta events for reasoning_content chunks - Add clarifying comments distinguishing standard vs custom reasoning fields - Maintain consistent error handling pattern with existing code Credits: Based on PR charmbracelet#1294 by @mmangkad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for handling the 'reasoning_content' field in streaming responses from custom OpenAI-compatible APIs, allowing models that return reasoning content in this field to display their chain of thought in Crush UI.
Previously, Crush only handled the 'reasoning' field but not the 'reasoning_content' field used by some custom servers.
CONTRIBUTING.md.