fix(sqlite): remove WAL pragma #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honestly I don't think we really need it. We basically only append to the messages tables, the default journaling seems enough to me. Using the default will also allow to use SMB shares, and reduce IO. Closes #473 See https://blog.sqlite.ai/journal-modes-in-sqlite See https://sqlite.org/pragma.html Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0
requested review from
Copilot,
kujtimiihoxha and
tauraamui
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the SQLite journal mode from WAL (Write-Ahead Logging) to DELETE mode to improve compatibility with SMB shares and reduce I/O operations. The change aligns with the database's append-only usage pattern for the messages table.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Less IO sounds nice :) |
andreynering
approved these changes
Oct 30, 2025
kujtimiihoxha
added a commit
that referenced
this pull request
Nov 6, 2025
This reverts commit bb96ca3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly I don't think we really need it.
We basically only append to the messages tables, the default journaling seems enough to me.
Using the default will also allow to use SMB shares, and reduce IO.
Closes #473
See https://blog.sqlite.ai/journal-modes-in-sqlite
See https://sqlite.org/pragma.html