-
Notifications
You must be signed in to change notification settings - Fork 898
feat(tui): reduce animations #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
caarlos0
wants to merge
10
commits into
main
Choose a base branch
from
static
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6e43d81
feat(tui): static spinner
caarlos0 a6c3bf4
refactor: rename to spinner
caarlos0 ba02a4b
feat(tui): reduce animations
caarlos0 cbfd5e6
Merge remote-tracking branch 'origin/main' into static
caarlos0 175acf2
feat: auto-enable if $SSH_TTY
caarlos0 6553c3f
Merge remote-tracking branch 'origin/main' into static
caarlos0 e4dd17e
fix: var name
caarlos0 0c4dd5c
fix: CRUSH_REDUCE_ANIMATIONS
caarlos0 0213bca
Merge remote-tracking branch 'origin/main' into static
caarlos0 53941c9
fix: import
caarlos0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package anim | ||
|
|
||
| import ( | ||
| "cmp" | ||
| "image/color" | ||
|
|
||
| tea "charm.land/bubbletea/v2" | ||
| "github.com/charmbracelet/lipgloss/v2" | ||
| ) | ||
|
|
||
| type noAnim struct { | ||
| Color color.Color | ||
| rendered string | ||
| id int | ||
| } | ||
|
|
||
| func newStatic(label string, foreground color.Color) Spinner { | ||
| a := &noAnim{Color: foreground} | ||
| a.SetLabel(label) | ||
| a.id = nextID() | ||
| return a | ||
| } | ||
|
|
||
| func (s *noAnim) SetLabel(label string) { | ||
| s.rendered = lipgloss.NewStyle(). | ||
| Foreground(s.Color). | ||
| Render(cmp.Or(label, "Working") + ellipsisFrames[2]) | ||
| } | ||
|
|
||
| func (s noAnim) Init() tea.Cmd { return stepCmd(s.id) } | ||
| func (s *noAnim) View() string { return s.rendered } | ||
| func (s *noAnim) Update(msg tea.Msg) (Spinner, tea.Cmd) { | ||
| switch msg := msg.(type) { | ||
| case StepMsg: | ||
| if msg.id != s.id { | ||
| // Reject messages that are not for this instance. | ||
| return s, nil | ||
| } | ||
| return s, stepCmd(s.id) | ||
| default: | ||
| return s, nil | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think showing just a white
Working...is a bit too boring. I wonder if we can improve it somehow. Perhaps add a colorful meaningful character as a prefix, at least to make it distinct from the actual text.This is probably a job for @meowgorithm 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed—I can come up with some stuff.