Dyno: Resolve auto module visibility statements eagerly #26461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incurs a penalty up front, but prevents odd ordering properties in the query system. It's a workaround for a query system bug detailed in chapel-lang#26459. Signed-off-by: Danila Fedorin <[email protected]>
DanilaFe
changed the title
benharsh
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incurs a penalty up front, but prevents odd ordering properties in the query system. It's a workaround for a query system bug detailed in #26459.
This way, cycles in the standard module dependency graph are always visited in the same order (starting with
ChapelBase). As a result, we don't create cycles over multiple generations. This workaround does not prevent the issue from occurring in other contexts, such as user projects with circular dependencies.Reviewed by @benharsh -- thanks!
Testing