Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake(conduwuit): unpin crane as the toml bug has been fixed #701

Merged
merged 1 commit into from
May 3, 2024

Conversation

girlbossceo
Copy link
Contributor

🐟 What?

Unpins crane from flake.nix for conduwuit builds

🎣 Why?

The TOML mangle bug has been fixed:

girlbossceo/conduwuit#298
ipetkov/crane#527 (comment)

@girlbossceo girlbossceo requested a review from a team as a code owner May 3, 2024 17:59
Copy link
Member

@PedroHLC PedroHLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for coming all the way here to update.

@PedroHLC PedroHLC merged commit 929f8b1 into chaotic-cx:main May 3, 2024
2 checks passed
@girlbossceo
Copy link
Contributor Author

@PedroHLC I saw the CI failed for the same TOML error. Is it not pulling the right crane version?

It's definitely fixed and released here: https://github.com/ipetkov/crane/blob/master/CHANGELOG.md#0164---2024-04-07

@PedroHLC
Copy link
Member

PedroHLC commented May 3, 2024

Failed to load source for ruma, caused by a TOML parse error.

@PedroHLC
Copy link
Member

PedroHLC commented May 5, 2024

So, their FlakeHub release was stuck. They fixed it now.
Which is being bumped at #704

@girlbossceo
Copy link
Contributor Author

Awesome!

oluceps pushed a commit to oluceps/nyx that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants