Remove inaccurate image validity check #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're opening the image with Pillow immediately after the check, we can simply skip it and let Pillow perform its own, more accurate image validity check. I’ve also refactored `imread2tensor` to eliminate the code duplicated from `imread2pil`. Note that the check function itself has been kept, as it’s used elsewhere in the code, apparently for dataset filtering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #260
Since we're opening the image with Pillow immediately after the check, we can simply skip it and let Pillow perform its own, more accurate image validity check. Note that the check function itself has been kept, as it’s used elsewhere in the code, apparently for dataset and directory filtering.
It might be worth considering the removal of this function in the remaining places as well, and handling any exceptions when the files are actually loaded. I’ll leave it to the maintainers to decide how this should be addressed.
I’ve also refactored
imread2tensorto eliminate the code duplicated fromimread2pil.