User: Use push functionality in webbrowsers - refs #3255 #6421
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import { arrayBufferToBase64, urlBase64ToUint8Array } from "../utils/pushUtils.js" | ||
| import axios from "axios" | ||
|
|
||
| export function usePushSubscription() { |
There was a problem hiding this comment.
Function usePushSubscription has 187 lines of code (exceeds 25 allowed). Consider refactoring.
| return true | ||
| } catch (e) { | ||
| console.error("Push subscription error:", e) | ||
| return false |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| } | ||
| } | ||
|
|
||
| async function checkSubscription(userId) { |
There was a problem hiding this comment.
Function checkSubscription has 57 lines of code (exceeds 25 allowed). Consider refactoring.
| } | ||
| } | ||
|
|
||
| async function unsubscribe(userId) { |
There was a problem hiding this comment.
Function unsubscribe has 33 lines of code (exceeds 25 allowed). Consider refactoring.
| } | ||
| } | ||
|
|
||
| async function subscribe(userId) { |
There was a problem hiding this comment.
Function subscribe has 48 lines of code (exceeds 25 allowed). Consider refactoring.
| import { arrayBufferToBase64, urlBase64ToUint8Array } from "../utils/pushUtils.js" | ||
| import axios from "axios" | ||
|
|
||
| export function usePushSubscription() { |
There was a problem hiding this comment.
Function usePushSubscription has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
| loading.value = true | ||
|
|
||
| try { | ||
| if (!userId) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return false | ||
| } | ||
|
|
||
| if (!("serviceWorker" in navigator) || !("PushManager" in window)) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| } | ||
| } | ||
|
|
||
| async function checkSubscription(userId) { |
There was a problem hiding this comment.
Function checkSubscription has 64 lines of code (exceeds 25 allowed). Consider refactoring.
| import { arrayBufferToBase64, urlBase64ToUint8Array } from "../utils/pushUtils.js" | ||
| import axios from "axios" | ||
|
|
||
| export function usePushSubscription() { |
There was a problem hiding this comment.
Function usePushSubscription has 194 lines of code (exceeds 25 allowed). Consider refactoring.
| import { arrayBufferToBase64, urlBase64ToUint8Array } from "../utils/pushUtils.js" | ||
| import axios from "axios" | ||
|
|
||
| export function usePushSubscription() { |
There was a problem hiding this comment.
Function usePushSubscription has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 5e5250c and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.