Add support for stacked area in timeline graphs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values on y Axis, since Highcharts handles that rather well
This was done so that users can have a widget with a, for example,
stacked area chart, for which you'd set the following options:
widget "Users", {
:title => "Some Title",
:type => :timeline,
:plot_style => :area,
:plot_options => { 'area' => { 'stacking' => 'normal' } },
:gauges => [ :my_gauge ]
}
Another nice option is 'stacking' => 'percent'
|
the only thing that bothers me is that the tests are not passing (on my machine). It mainly looks like typing errors... Do they pass on your machine? |
|
Master isn't passing either, with the same failures... |
|
I know, the thing is that travis says that the original repo is passing. I pulled it and ran I was more wondering if we're setting the environment properly. other than that, feel free to move this to qa |
|
Let's get a pull request up to the main project! |
|
Done. Waitin' Juan C. Müller On Friday, June 8, 2012 at 11:18 AM, Ross Kaffenberger wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.