Stock fix #223
Merged
Stock fix #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#220
http://worldtradingdata.com/ redirects to https://marketstack.com/ now. Looking at marketStack's API documentation, free users are limited to 100 requests per month and multi-ticker-requests are treated as one request per ticker. I imagine free users would run out quickly
Researched around and found https://finage.co.uk/ which has real-time stock price and 1000 requests per month for free users. The API is also a bit more manageable for single/multi ticker requests.
Changes compared to old command:
When ticker does not exist
When API key is invalid
