Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Presence events and functions. New msglist command #202

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Kyrisx
Copy link
Collaborator

@Kyrisx Kyrisx commented Jun 18, 2021

Updated the presence event code to properly detect user status changes. Msgs command will now send stored messages to users when their status changes to "online" or "idle". Currently, if a Msg is created while a user is already online/idle, it won't be sent until the status changes. Msglist command retrieves messages the caller has sent to the target.

@chalda
Copy link
Owner

chalda commented Jun 18, 2021

can we move these commands to a separate folder similar to other plugins. its a fairly large chunk of isolated code

@F9Alejandro
Copy link
Collaborator

Be sure to also put in checks for user allowing DMs for the messagelist. It would help prevent crashes and could possible keep the messages until the user switches the permissions for DMs for that server.

It would also be beneficial if this is converted to a sqlite db instead of storing the data in memory just incase the bot crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants