First pull/push #169
Closed
First pull/push #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really needs a gitignore file
… going to have the same id in any other guild)
On branch role-perm Changes to be committed: modified: plugins/Admin/admin.js
|
So many commits just to get back to original lol. |
fixed issue with args[] missing split from arg. fixed issue with role var in .find clashed with role var with role.id (renamed to roleid) fixed users own role being removed instead of mentioned user.
chalda
reviewed
Nov 8, 2020
chalda
reviewed
Nov 8, 2020
changed != to !==
chalda
reviewed
Nov 8, 2020
Changes to be committed: modified: plugins/Admin/admin.js Made statements easier to read and understand, slight check of if msg came from a server or not though if statement, should add some sort of error message that is based on if the command is ran in a dm or if the sender doesn't have guild permission of ROLE
|
Tested new check of permission and works perfectly, typically no one would give manage roles perm unless they are an admin or higher. |
Einarin
reviewed
Dec 1, 2020
| var args = arg.split(" "); | ||
| var user, role; | ||
| if(msg.member.hasPermission("MANAGE_ROLES")){ |
There was a problem hiding this comment.
It would be nice to check if the bot has MANAGE_ROLES so that it can fail gracefully if it doesn't.
There was a problem hiding this comment.
could also do another try catch for it as well, or a quick change to add & to the if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed admin.js to have userRole for request #70