Skip to content

Conversation

@nelsonlaidev
Copy link
Collaborator

@nelsonlaidev nelsonlaidev commented Oct 27, 2025

Closes #

📝 Description

Preview: https://zag-website-git-docs-image-cropper-chakra-ui.vercel.app/components/react/image-cropper

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

⚠️ No Changeset found

Latest commit: d312cf0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
zag-nextjs Ready Ready Preview Oct 28, 2025 5:07pm
zag-solid Ready Ready Preview Oct 28, 2025 5:07pm
zag-svelte Ready Ready Preview Oct 28, 2025 5:07pm
zag-vue Ready Ready Preview Oct 28, 2025 5:07pm
zag-website Ready Ready Preview Oct 28, 2025 5:07pm

@segunadebayo
Copy link
Member

Nice work! Some thoughts after reviewing

  • Let's visually hide the selection area until it's entirely measured (maybe with opacity or visibility hidden)
  • Let's export handles from the package so users can import like imageCropper.handles and not have to this code below:
const handles: imageCropper.HandlePosition[] = [
  "top-left",
  "top",
  "top-right",
  "right",
  "bottom-right",
  "bottom",
  "bottom-left",
  "left",
]
  • In the docs demo, let's have a button to show the preview of the cropped image

@segunadebayo segunadebayo merged commit 3eadf31 into main Oct 28, 2025
20 checks passed
@segunadebayo segunadebayo deleted the docs/image-cropper branch October 28, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants