fix: make the image cropper responsive #2805
Merged
+259
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 016b381 The changes in this PR will be included in the next version bump. This PR includes changesets to release 81 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const viewportEl = dom.getViewportEl(scope) | ||
| if (!viewportEl) return | ||
|
|
||
| const resizeObserver = new ResizeObserver(() => { |
There was a problem hiding this comment.
Let's scope this to the correct window instance.
Suggested change
| const resizeObserver = new ResizeObserver(() => { | |
| const win = scope.getWindow() | |
| const resizeObserver = new win.ResizeObserver(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
Make the image cropper responsive. When the viewport or image size changes, recalculate the crop area's size and position.
Also added e2e tests for this.
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information