-
Notifications
You must be signed in to change notification settings - Fork 177
feat: image cropper #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: image cropper #3677
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const handlePositions = [ | ||
| 'top-left', | ||
| 'top', | ||
| 'top-right', | ||
| 'right', | ||
| 'bottom-right', | ||
| 'bottom', | ||
| 'bottom-left', | ||
| 'left', | ||
| ] as const | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the next zag version, we export the imageCropper.handles to replace this array
|
I've added a new grid part to the image cropper in the latest zag. Can you bump the versions and check? Update: I've bumped the zag version locally |
|
@segunadebayo Thanks for refactoring the image cropper and adding the new grid part. The update is blocked by chakra-ui/zag#2819 currently. I suggest adding a script to check for any missing types in the machines. Based on my observations, all types should be re-exported except for Should I go ahead to add it in the zag codebase? |
|
@nelsonlaidev, Yes, please add that script; it'll be very useful. |

No description provided.