Generator: Add bikeNumberValidation and fix carNumberValidation #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahini
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Ce serait bien de mettre ces validations plutôt dans evolution-common si possible? Je ne pense pas que ça nécessite quoi que ce soit frontend? Peut-être des trucs users. En tout, cas, il faudrait voir à emmener ça dans un package d'evolution, pour qu'une enquête qui n'utlise pas le génrérateur puisse en profiter
Oui, je suis d'accord, j'ai donné mon avis à ce propos dans #532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Generator: Add bikeNumberValidation and fix carNumberValidation