Add InputDatePicker type in inputTypes.ts #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahini
approved these changes
Jul 18, 2024
| @@ -298,3 +298,21 @@ export type InputMapFindPlace = InputMapFindPlaceBase & { | |||
|
|
|||
| /* InfoMap widgetConfig Type */ | |||
| export type InfoMap = InfoMapWidgetConfig; | |||
|
|
|||
| /* InputDatePicker widgetConfig Type */ | |||
| export type InputDatePicker = { | |||
There was a problem hiding this comment.
Voir le InputDatePickerType dans WidgetConfig.ts. D'ailleurs il faudrait vraiment uniformiser les types entre le générateur et WidgetConfig, mais la façon dont ils sont décrits ne le permet pas efficacement actuellement, pour les questions du moins. Mais les types du WidgetConfig sont plus complets. Par exemple, pour locale, la clé est le code de langue et non fixé à 'fr', 'en' et les max/minDate peuvent aussi être une date hardcodée et pas qu'une fonction.
There was a problem hiding this comment.
C'est bon. Il va falloir uniformiser cela dès que possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Justification
There is no type for InputDatePicker, it's easy to make errors with this input.
Description
Add InputDatePicker type in inputTypes.ts