Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the lint warnings in pkg/linter #866

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix the lint warnings in pkg/linter #866

merged 1 commit into from
Nov 28, 2023

Conversation

vaikas
Copy link
Member

@vaikas vaikas commented Nov 28, 2023

Melange Pull Request Template

Fix the linter warnings. Left one about stuttering include, as we can fix that if we want to or silence it.

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@vaikas vaikas enabled auto-merge November 28, 2023 13:34
@vaikas vaikas merged commit f5a31ea into chainguard-dev:main Nov 28, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaikas @imjasonh