Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GID its own type to prevent defaulting to 0 #1449

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

jdolitsky
Copy link
Member

A follow up to #1407 which had the unintended side effect of missing gid value defaulting to 0

@jdolitsky jdolitsky marked this pull request as ready for review December 19, 2024 20:24
@EyeCantCU EyeCantCU merged commit 6f4d66c into chainguard-dev:main Dec 19, 2024
15 checks passed
@pnasrat
Copy link
Member

pnasrat commented Jan 2, 2025

@jdolitsky note the logging out of gid broke with this as the format string is now of a pointer not of the uint32

2025/01/02 16:38:15 INFO   accounts:
2025/01/02 16:38:15 INFO     runas:  
2025/01/02 16:38:15 INFO     users:
2025/01/02 16:38:15 INFO       - uid=1000(build) gid=824636385816
2025/01/02 16:38:15 INFO     groups:
2025/01/02 16:38:15 INFO       - gid=1000(build) members=[build]
2025/01/02 16:38:15 INFO auth configured for: [apk.cgr.dev]

log.Infof(" - uid=%d(%s) gid=%d", u.UID, u.UserName, u.GID)

@jdolitsky jdolitsky deleted the gid-type branch January 7, 2025 15:29
pnasrat pushed a commit that referenced this pull request Jan 7, 2025
Follow up to comment here:
#1449 (comment)

cc @pnasrat

Signed-off-by: Josh Dolitsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants