Skip to content

Commit

Permalink
Merge pull request cupy#8060 from asi1024/rm-vectorstrength-xfail
Browse files Browse the repository at this point in the history
Remove some `signal.vectorstrength` xfail tests
  • Loading branch information
takagi authored and chainer-ci committed Jan 5, 2024
1 parent 8b7dd02 commit 531bebc
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions tests/cupyx_tests/scipy_tests/signal_tests/test_spectral.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@

import sys
import pytest

import numpy as np
Expand Down Expand Up @@ -1297,13 +1295,7 @@ def test_partial_2dperiod(self, xp, scp):
strength, phase = scp.signal.vectorstrength(events, period)
return strength, phase

@pytest.mark.xfail(
condition=(
sys.platform == 'linux' and
not (11030 <= runtime.runtimeGetVersion() < 11040 and
testing.installed('scipy==1.8.*'))
),
reason='It fails in the CI')
@testing.with_requires('scipy>1.11')
@testing.numpy_cupy_allclose(scipy_name='scp', rtol=1e-7, atol=1e-7)
def test_opposite_1dperiod(self, xp, scp):
events = xp.array([0, .25, .5, .75])
Expand All @@ -1312,13 +1304,7 @@ def test_opposite_1dperiod(self, xp, scp):
strength, phase = scp.signal.vectorstrength(events, period)
return strength, phase

@pytest.mark.xfail(
condition=(
sys.platform == 'linux' and
not (11030 <= runtime.runtimeGetVersion() < 11040 and
testing.installed('scipy==1.8.*'))
),
reason='It fails in the CI')
@testing.with_requires('scipy>1.11')
@testing.numpy_cupy_allclose(scipy_name='scp', rtol=1e-7, atol=1e-7)
def test_opposite_2dperiod(self, xp, scp):
events = xp.array([0, .25, .5, .75])
Expand Down

0 comments on commit 531bebc

Please sign in to comment.