Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect jquery object with both instanceof and jquery attribute #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zation
Copy link

@zation zation commented Apr 20, 2015

When I use chai-jquery with browserify, I found some methods are broken:

  • contain
  • match
  • empty
  • exist

Because the detection of obj instanceof $ is always false. That is because the $ object is not the same as the jquery object I used to initialize obj. So I add another detection obj.jquery to handle this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant