Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendertarget interfaces #368

Merged
merged 43 commits into from
Jul 6, 2017
Merged

Rendertarget interfaces #368

merged 43 commits into from
Jul 6, 2017

Conversation

scheibel
Copy link
Member

@scheibel scheibel commented Jun 16, 2017

ToDo:

  • RenderTarget and RenderInterface hardening (make resistant to unconnected slots and nullptr-RenderTargets)
  • Complete documentation on changed/introduced interfaces
  • Redesign RenderTarget and RenderInterface interfaces
  • Add blit to canvas if pipeline doesn't render in provided color RenderTarget
  • Check all stages that renders using the RenderInterface
  • Check all usages of RenderInterface if the more-specific CanvasInterface may be used
  • Move input/output queries to Stage interface
  • Fix BlitStage logic
  • Introduce subclasses for RenderTarget
  • Document workarounds in pipeline design using RenderTarget interface
  • Framebuffer management by RenderInterface
  • Add DepthStencilRenderTarget subtype to handle combined depth-stencil attachments correctly.

Delayed tasks:

@scheibel
Copy link
Member Author

Current state: ShapeDemo is working using a RenderTarget instead of Framebuffer interface.

@scheibel scheibel changed the title [WIP] Rendertarget interfaces Rendertarget interfaces Jun 28, 2017
@scheibel
Copy link
Member Author

I think the first milestone for rendertarget interfaces is reached and this PR is now available for review and merging.
There are some open tasks which I want to address later as separate issues.

@scheibel scheibel changed the title Rendertarget interfaces [WIP] Rendertarget interfaces Jun 29, 2017
@scheibel scheibel changed the title [WIP] Rendertarget interfaces Rendertarget interfaces Jun 30, 2017
@scheibel scheibel mentioned this pull request Jul 4, 2017
@scheibel scheibel changed the title Rendertarget interfaces [WIP] Rendertarget interfaces Jul 4, 2017
@scheibel scheibel changed the title [WIP] Rendertarget interfaces Rendertarget interfaces Jul 4, 2017
@scheibel
Copy link
Member Author

scheibel commented Jul 4, 2017

I merged the current master. This PR is now reviewable/mergable.

I fixed most of the old example pipelines/stages, too.
However, I suggest @Tobias1595 has a further look on the examples that should remain.

@scheibel scheibel merged commit 4a2a32f into master Jul 6, 2017
@scheibel scheibel deleted the rendertarget_interfaces branch July 6, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant