Fix the use of custom display configuration files #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axios when running within Node.js doesn't support the file:// protocol. This changes it so that it explicitly uses Node.js's `fs` package to load local files if `file://` is detected in the URI. This also fixes the fact that the custom display configuration was not being loaded on save, only on startup of the plugin. It also fixes it so that if you remove a custom display configuration it will fall back to the default configuration without needing to restart the plugin. This fixes cgiesche#342
tlusk
force-pushed
the
bugfix/fix-custom-display-configuration
branch
from
bbe1d79 to
35c314e
Compare
cgiesche
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axios when running within Node.js doesn't support the file:// protocol. This changes it so that it explicitly uses Node.js's
fspackage to load local files iffile://is detected in the URI.This also fixes the fact that the custom display configuration was not being loaded on save, only on startup of the plugin.
It also fixes it so that if you remove a custom display configuration it will fall back to the default configuration without needing to restart the plugin.
This fixes #342