feat: final draw csv generation #445
Open
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruioliveira02
force-pushed
the
ro/final-draw
branch
from
8d7efd7 to
0a3c99b
Compare
ruioliveira02
force-pushed
the
ro/final-draw
branch
from
0a3c99b to
2ee7fa1
Compare
ruioliveira02
requested review from
joaodiaslobo,
MarioRodrigues10 and
nunom27
joaodiaslobo
requested changes
Jan 21, 2025
| conn = | ||
| conn | ||
| |> put_resp_content_type("text/csv") | ||
| |> put_resp_header("content-disposition", "attachment; filename=\"large_data.csv\"") |
There was a problem hiding this comment.
Suggested change
| |> put_resp_header("content-disposition", "attachment; filename=\"large_data.csv\"") | |
| |> put_resp_header("content-disposition", "attachment; filename=\"final_draw.csv\"") |
Comment on lines
+114
to
+119
| scope "/downloads" do | ||
| pipe_through [:require_staff_user] | ||
| get "/final_draw", CSVController, :final_draw | ||
| end | ||
|
|
||
| scope "/dashboard", Backoffice do |
There was a problem hiding this comment.
Didn't this remove the :require_staff_user pipeline from the dashboard?
joaodiaslobo
requested changes
Jan 21, 2025
Comment on lines
+39
to
+43
| defp final_draw_lines(attendee) do | ||
| for _ <- 1..attendee.attendee.entries do | ||
| [[attendee.id, attendee.name, attendee.handle]] | ||
| end | ||
| end |
There was a problem hiding this comment.
Suggested change
| defp final_draw_lines(attendee) do | |
| for _ <- 1..attendee.attendee.entries do | |
| [[attendee.id, attendee.name, attendee.handle]] | |
| end | |
| end | |
| defp final_draw_lines(user) do | |
| for _ <- 1..user.attendee.entries do | |
| [[user.id, user.name, user.handle]] | |
| end | |
| end |
ruioliveira02
commented
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #431 to be merged first