Jc/register page #36
Jc/register page #36
Conversation
JoseBambora
force-pushed
the
jc/register_page
branch
from
83f5dc7 to
80f7f8b
Compare
| @@ -15,6 +15,7 @@ defmodule KaraokiumWeb.Admin.PerformanceLive.New do | |||
| socket | |||
| |> assign(:performance, %Performance{}) | |||
| |> assign(:page_title, "New Performance") | |||
| |> assign(:karaoke_id, karaoke_id)} | |||
| |> assign(:karaoke_id, karaoke_id) | |||
| |> assign(:permissions, socket.assigns.current_user.permissions)} | |||
There was a problem hiding this comment.
Where are you using this?
There was a problem hiding this comment.
I am using this on the same folder, on the file new.html.heex. I made this in order to have the same page returning to 2 different pages. This is important when we have normal users, that doesn't have any permission, and they want to register their team, their return page will be the normal karaoke page. The rest users that have permissions will go directly to the admin page when they finished registering some team. I made this for the reason to not creating another new.ex and new.html.heex which only difference would be the return page.
|
|
||
| :sysadmin -> | ||
| acc ++ sysadmin_menu(conn) |
There was a problem hiding this comment.
You shouldn't change this. Each permission opens the possibility to navigate to different places and do different things.
There was a problem hiding this comment.
Ok. I am commiting it to another branch since this branch is for register_page and not for navbar.
| ] | ||
| } | ||
| ] | ||
| end | ||
|
|
||
| defp sysadmin_menu(conn) do | ||
| [ | ||
| %{title: "LiveDashboard", url: Routes.live_dashboard_path(conn, :home), submenu: []} |
There was a problem hiding this comment.
A sysadmin of the system should only get permission to access the Live Dashboard in order to monitor the application.
There was a problem hiding this comment.
Ok. I am commiting it to another branch since this branch is for register_page and not for navbar.
JoseBambora
force-pushed
the
jc/register_page
branch
from
80f7f8b to
ed492b7
Compare
Give the possibility for the users creating performances on karaokes. This will reduce the time, since everyone can create their team performance, instead of being the admin creating every team performance.