Skip to content

feat: events page #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Mar 13, 2025
Merged

feat: events page #70

merged 39 commits into from
Mar 13, 2025

Conversation

@JoaoCoelho2003
Copy link
Contributor

@JoaoCoelho2003 JoaoCoelho2003 commented Jan 31, 2025 •
edited
Loading

  • Calendar
  • Event Card
  • Event List

Refers to: #39

Right now the page looks like this:

image

@netlify
Copy link

netlify bot commented Jan 31, 2025 •
edited
Loading

✅ Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit 3fa0d34
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/67d33e04e4c4e50008c6c8c3
😎 Deploy Preview https://deploy-preview-70--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoaoCoelho2003 JoaoCoelho2003 marked this pull request as draft February 3, 2025 16:15
@JoaoCoelho2003 JoaoCoelho2003 self-assigned this Feb 4, 2025
@diogogmatos
Copy link
Member

diogogmatos commented Feb 17, 2025

You can now use this endpoint: https://calendario.cesium.pt/api/transfer/events?filterId=-1&groupId=0&groupId=7&groupId=9&groupId=10&groupId=11&groupId=12 to fetch CeSIUM events from Calendarium 🙌🏼

This was linked to issues Feb 17, 2025
feat: calendar components #36
Closed
feat: /events page #39
Closed
@diogogmatos
Copy link
Member

diogogmatos commented Feb 24, 2025

Is this ready for review? 👀

@JoaoCoelho2003
Copy link
Contributor Author

JoaoCoelho2003 commented Feb 24, 2025

Is this ready for review? 👀

There are still some differences between the design and the actual implementation that need to be discussed, particularly regarding the division of events into past and upcoming. But after that it should be done and ready for review.

@JoaoCoelho2003
feat: added spinner while events are being loaded
edf6856
@JoaoCoelho2003
feat: ability to select a date and the list only shows events that ha…
ae7ba04 
…ppen in the day, hover effect in the calendar and other minor fixes
@JoaoCoelho2003
fix: width of the event links not overflowing the event card component
ac66fc2
@JoaoCoelho2003
fix: format
4d4139c
@JoaoCoelho2003
feat: added skeletons while events are being loaded
69acc77
@JoaoCoelho2003
fix: title for past/upcoming events being shown even though there are…
4a0edb1 
… no events in the timeline
@JoaoCoelho2003
refactor: show more now only shows 5 more events (the more you press …
ba78dc3 
…the more it shows until there are no events left
@JoaoCoelho2003
refactor: the small indicator of an event in a certain day is not hid…
e74a15f 
…den by figure that appears once a day is selected and added a message to indicate that a day has no events
@JoaoCoelho2003
fix: selected event indicator color
48c6b97
diogogmatos
diogogmatos reviewed Mar 12, 2025
View reviewed changes
diogogmatos
diogogmatos reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@diogogmatos diogogmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay in the relative position and not move with scroll (maybe change from absolute to fixed or sticky).

Screencast_20250312_142815.mp4

diogogmatos
diogogmatos reviewed Mar 12, 2025
View reviewed changes
@diogogmatos
Copy link
Member

diogogmatos commented Mar 12, 2025

Multiple day events or all day events should not show a time:

image

You can identify these type of events by the way their date is formatted. An all day event will have start time and end time set to 0:00. A multiple-day event will have a start time of 0:00 and an end time of 23:59.

For multiple day events, you can also place the start date and end date, and not just the start date. For example: 28/03 - 30/03

@JoaoCoelho2003
Copy link
Contributor Author

JoaoCoelho2003 commented Mar 12, 2025

@diogogmatos Everything's done and working, the only thing that is worth mentioning is that i changed a little bit the design of the hover modal. Since I had something to fix there and there is no design for the component, I decided to change it a little and in my opinion it looks better now but when you review the code please do share your thoughts.

image

joaodiaslobo
joaodiaslobo approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! 🤘🚀

@diogogmatos diogogmatos merged commit 06b0f60 into main Mar 13, 2025
4 checks passed
@diogogmatos diogogmatos deleted the jc/eventsPage branch March 13, 2025 20:27
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hydrogen - Development Mar 13, 2025
DevJoanaC pushed a commit that referenced this pull request Mar 23, 2025
@JoaoCoelho2003
feat: events page (#70)
07d01df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaodiaslobo joaodiaslobo joaodiaslobo approved these changes

@diogogmatos diogogmatos Awaiting requested review from diogogmatos

@nunom27 nunom27 Awaiting requested review from nunom27

Assignees

@JoaoCoelho2003 JoaoCoelho2003

Labels

p: critical 🚨

Projects

Hydrogen - Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: /events page feat: calendar components

4 participants

@JoaoCoelho2003 @diogogmatos @joaodiaslobo