-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: about section layout #69
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cesium-hydrogen-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small comments. Great work! 🚀
I was inspecting this further and I noticed some changes are going to need to be made on the layout because of the about page. Right now, there's some universal layout paddings for every page, however, the about page has sections that go all the way to the border of the screen:
Which means these paddings can't be applied in layout.tsx
for every page, but will need to be applied to each page. Basically, this PR is gonna suffer some small changes because of that, because I'm going to create some universal constants containing the horizontal and vertical global layout paddings, and then the horizontal paddings you're applying manually will be replaced by a variable. (We need to wait for #59 )
No description provided.