Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: about section layout #69

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: about section layout #69

wants to merge 5 commits into from

Conversation

gxnca
Copy link
Contributor

@gxnca gxnca commented Jan 21, 2025

No description provided.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit 543ca2b
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/6798d2e00848c90008aa6049
😎 Deploy Preview https://deploy-preview-69--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gxnca gxnca self-assigned this Jan 21, 2025
@gxnca gxnca requested review from nunom27 and diogogmatos January 22, 2025 23:11
@gxnca gxnca marked this pull request as ready for review January 22, 2025 23:11
@gxnca gxnca linked an issue Jan 24, 2025 that may be closed by this pull request
Copy link
Member

@diogogmatos diogogmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small comments. Great work! 🚀

I was inspecting this further and I noticed some changes are going to need to be made on the layout because of the about page. Right now, there's some universal layout paddings for every page, however, the about page has sections that go all the way to the border of the screen:

image

Which means these paddings can't be applied in layout.tsx for every page, but will need to be applied to each page. Basically, this PR is gonna suffer some small changes because of that, because I'm going to create some universal constants containing the horizontal and vertical global layout paddings, and then the horizontal paddings you're applying manually will be replaced by a variable. (We need to wait for #59 )

src/components/aboutsection.tsx Outdated Show resolved Hide resolved
src/components/aboutsection.tsx Show resolved Hide resolved
@gxnca gxnca requested a review from diogogmatos January 28, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

feat: AboutSection component
2 participants