Skip to content

refactor(ScrollAnchor): pixel-accurate anchor and rename module #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcottercertinia merged 4 commits into from
May 9, 2026
Merged

refactor(ScrollAnchor): pixel-accurate anchor and rename module #757

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3eef9c4
refactor(ScrollAnchor): rename MiddleRowFocus and eliminate render jump
lukecotter May 9, 2026
c3951d6
refactor(ScrollAnchor): simplify and reduce hot-path layout work
lukecotter May 9, 2026
4f7f723
refactor(ScrollAnchor): drop timestamp dependency for data-agnostic f…
lukecotter May 9, 2026
ad3cefa
Merge branch 'main' into feat-native-scroll-anchor-feel
lukecotter May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions log-viewer/src/features/call-tree/components/AggregatedTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ export function createAggregatedTable(
placeholder: 'No Call Tree Available',
height: '100%',
maxHeight: '100%',
// @ts-expect-error custom property for module/RowKeyboardNavigation + MiddleRowFocus
// @ts-expect-error custom property for module/RowKeyboardNavigation + ScrollAnchor
rowKeyboardNavigation: true,
middleRowFocus: true,
scrollAnchor: true,
dataTree: true,
dataTreeChildColumnCalcs: false,
dataTreeBranchElement: '<span/>',
Expand Down
2 changes: 1 addition & 1 deletion log-viewer/src/features/call-tree/components/BottomUpTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function createBottomUpTable(
height: '100%',
maxHeight: '100%',
rowKeyboardNavigation: true,
middleRowFocus: true,
scrollAnchor: true,
dataTree: true,
dataTreeChildColumnCalcs: false,
dataTreeBranchElement: '<span/>',
Expand Down
4 changes: 2 additions & 2 deletions log-viewer/src/features/call-tree/components/TableShared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { Tabulator } from 'tabulator-tables';

import * as CommonModules from '../../../tabulator/module/CommonModules.js';
import { Find } from '../../../tabulator/module/Find.js';
import { MiddleRowFocus } from '../../../tabulator/module/MiddleRowFocus.js';
import { RowKeyboardNavigation } from '../../../tabulator/module/RowKeyboardNavigation.js';
import { RowNavigation } from '../../../tabulator/module/RowNavigation.js';
import { ScrollAnchor } from '../../../tabulator/module/ScrollAnchor.js';
import type { AggregatedRow, BottomUpRow } from '../utils/Aggregation.js';
import type { MergedCalltreeRow } from '../utils/MergeAdjacent.js';

Expand All @@ -24,7 +24,7 @@ export interface TableCallbacks {

export function registerTableModules(): void {
Tabulator.registerModule(Object.values(CommonModules));
Tabulator.registerModule([RowKeyboardNavigation, RowNavigation, MiddleRowFocus, Find]);
Tabulator.registerModule([RowKeyboardNavigation, RowNavigation, ScrollAnchor, Find]);
}

export function headerSortElement(_column: unknown, dir: string): string {
Expand Down
4 changes: 2 additions & 2 deletions log-viewer/src/features/call-tree/components/TimeOrderTable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ export function createTimeOrderTable(
maxHeight: '100%',
// custom property for datagrid/module/RowKeyboardNavigation
rowKeyboardNavigation: true,
// custom property for module/MiddleRowFocus
middleRowFocus: true,
// custom property for module/ScrollAnchor
scrollAnchor: true,
dataTree: true,
dataTreeChildColumnCalcs: false,
dataTreeBranchElement: '<span/>',
Expand Down
335 changes: 0 additions & 335 deletions log-viewer/src/tabulator/module/MiddleRowFocus.ts
View file
Open in desktop

This file was deleted.

Loading
Loading